Find button does not work when ENTER is pressed

Details

Description

1. Open SQL Editor and write some statement
2. Press CTRL+F - Find windows pops-up
3. type something in the input search box and press enter

Expected result - Starts finding in the current editor
Actual result - Nothing happens. You have to either manually pres 'Find...' button, or press ALT+n

Additional enhancement

  • Search settings (checkboxes) are not persisted. I have to choose 'Case sensitive' and 'Wrap search' every time I use the search functionality. This can be persisted in my preferences forever.

Issue Links

relates to

New Feature - A new feature of the product, which has yet to be developed. TOOLS-51 Supporting Short keys as many as, and supporting "Enter" key when entering values on the UI menu

  • Major - Major loss of function.
  • In Progress - This issue is being actively worked on at the moment by the assignee.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Isaiah Choe added a comment -

Test case

test for storing checked options
1. press CTRL+F keys in Query Editor
2. check "Match case", "Wrap search", "Match whole word only" checkbox
3. close find dialog
4. re-open find dialog
5. whether checked options are right?
6. quit CM/CQB
7. after run CM/CQB, press CTRL+F keys in Query Editor
8. whether checked options are right?
9. uncheck "Wrap search" checkbox, close dialog
10. restart CM/CQB
11. press CTRL+F keys in Query Editor
12. whether checked options are right?

test for enter key for searching to start
1. press CTRL + F on Query Editor
2. input some keyword what you want to find on Find what
3. press enter key, is it work?
4. input some keyword on Find what and Replace with
5. press enter key, can it replace some keyword?
6. focus on Find what
7. press enter key, can it find without replace keyword?
(if cursor on Find what and press enter key, it will be started to find something,
but, if you focus on "Replace with", it will be tried to find and replace something.)

Show
Isaiah Choe added a comment - Test case test for storing checked options 1. press CTRL+F keys in Query Editor 2. check "Match case", "Wrap search", "Match whole word only" checkbox 3. close find dialog 4. re-open find dialog 5. whether checked options are right? 6. quit CM/CQB 7. after run CM/CQB, press CTRL+F keys in Query Editor 8. whether checked options are right? 9. uncheck "Wrap search" checkbox, close dialog 10. restart CM/CQB 11. press CTRL+F keys in Query Editor 12. whether checked options are right? test for enter key for searching to start 1. press CTRL + F on Query Editor 2. input some keyword what you want to find on Find what 3. press enter key, is it work? 4. input some keyword on Find what and Replace with 5. press enter key, can it replace some keyword? 6. focus on Find what 7. press enter key, can it find without replace keyword? (if cursor on Find what and press enter key, it will be started to find something, but, if you focus on "Replace with", it will be tried to find and replace something.)
Hide
Permalink
高艳铭 added a comment -

Now there are two question:

Q1
1 when there is sql in query editor
SELECT "i" FROM "a1";
2 Press ctrl+F, set find what to i, set replace with to j
3 Put the cursor to replace with, then press enter

Actual result:
the first it will find the i, the second press,it will replace and pop "String is not found"

Q2
shall we save direction ?

Show
高艳铭 added a comment - Now there are two question: Q1 1 when there is sql in query editor SELECT "i" FROM "a1"; 2 Press ctrl+F, set find what to i, set replace with to j 3 Put the cursor to replace with, then press enter Actual result: the first it will find the i, the second press,it will replace and pop "String is not found" Q2 shall we save direction ?
Hide
Permalink
高艳铭 added a comment -

Q3
1 When I choose SELECT "i" FROM "a1"; Press ctrl+F, set find what to i, set replace with to j
2 Click the replace

Actual result
It will replace all the sql to j. It won't replace i to j.

Addtional:

1 When I choose SELECT "i" FROM "a1"; Press ctrl+F, set find what to i, set replace with to j
2 Click find, it can find the i.
So why can find i,but cannot replace i. And how to replace one string in choosed area?

Show
高艳铭 added a comment - Q3 1 When I choose SELECT "i" FROM "a1"; Press ctrl+F, set find what to i, set replace with to j 2 Click the replace Actual result It will replace all the sql to j. It won't replace i to j. Addtional: 1 When I choose SELECT "i" FROM "a1"; Press ctrl+F, set find what to i, set replace with to j 2 Click find, it can find the i. So why can find i,but cannot replace i. And how to replace one string in choosed area?
Hide
Permalink
Isaiah Choe added a comment -

If you set focus on the "replace with" field, it will use the replace function. It is not a bug.
If you click a find button and then press enter key, it will be focused on "Find what" field not a "Replace with" field.

Show
Isaiah Choe added a comment - If you set focus on the "replace with" field, it will use the replace function. It is not a bug. If you click a find button and then press enter key, it will be focused on "Find what" field not a "Replace with" field.
Hide
Permalink
高艳铭 added a comment -

Fixed in CM8.4.1.2109 and CQB 8.4.1.2109

Show
高艳铭 added a comment - Fixed in CM8.4.1.2109 and CQB 8.4.1.2109

People

  • Assignee:
    高艳铭
    Reporter:
    Cristian Romanescu
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:

Time Tracking

Estimated:
Not Specified
Original Estimate - Not Specified
Remaining:
0m
Remaining Estimate - 0 minutes
Logged:
1h
Time Spent - 1 hour