Uploaded image for project: 'ngrinder'
  1. ngrinder
  2. NGRINDER-682

Adjust logger level to see only necessary logs

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.2.3
    • Fix Version/s: 3.3
    • Component/s: controller
    • Labels:
      None

      Description

      Currently some logs are unnecessarily marked as "ERROR"

      For example, the terminating test job always report log with ERROR marker even if it's the part of normal process.

      {code}
      @Scheduled(fixedDelay = PERFTEST_TERMINATION_FREQUENCY_MILLISECONDS)
      public void finishTest() {
      for (PerfTest each : perfTestService.getAbnoramlTestingPerfTest()) {
      LOG.error("Terminate {}", each.getId());
      SingleConsole consoleUsingPort = consoleManager.getConsoleUsingPort(each.getPort());
      doTerminate(each, consoleUsingPort);
      cleanUp(each);
      notifyFinsish(each, StopReason.TOO_MANY_ERRORS);
      }

      for (PerfTest each : perfTestService.getStopRequestedPerfTest()) {
      LOG.error("Stop test {}", each.getId());
      SingleConsole consoleUsingPort = consoleManager.getConsoleUsingPort(each.getPort());
      doCancel(each, consoleUsingPort);
      cleanUp(each);
      notifyFinsish(each, StopReason.CANCEL_BY_USER);
      }

      for (PerfTest each : perfTestService.getTestingPerfTest()) {
      SingleConsole consoleUsingPort = consoleManager.getConsoleUsingPort(each.getPort());
      if (isTestFinishCandidate(each, consoleUsingPort)) { doFinish(each, consoleUsingPort); cleanUp(each); notifyFinsish(each, StopReason.NORMAL); }
      }

      }{code}

      This makes it harder to identify the real errors from generic logs.
      Therefore it's better to change these error marker into info marker if it's not necessary.

        Activity

        Hide
        junoyoon JunHo Yoon added a comment -

        Fixed.

        Show
        junoyoon JunHo Yoon added a comment - Fixed.
        Hide
        junoyoon JunHo Yoon added a comment -

        Fixed

        Show
        junoyoon JunHo Yoon added a comment - Fixed

          People

          • Assignee:
            junoyoon JunHo Yoon
            Reporter:
            junoyoon JunHo Yoon
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: